Skip to content

REST API: Migrate system status endpoints #8604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 16, 2023
Merged

REST API: Migrate system status endpoints #8604

merged 7 commits into from
Jan 16, 2023

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jan 10, 2023

Closes: #8602

Description

This PR continues the migration for the REST API project, this time is for system status endpoints:

  • Updated the mappers for system status and system plugins.
  • Enable REST API for system status endpoints.

Testing instructions

  • Enable the feature flag applicationPasswordAuthenticationForSiteCredentialLogin and build the app.
  • Log out of the app or skip onboarding if needed.
  • On the prologue screen, select Enter your site address and proceed with the address of your self-hosted site.
  • Proceed to log in with your site credentials.
  • After the login succeeds, you should be navigated to the home screen.
  • Navigate to the Menu app and select Settings.
  • Notice on the row "WooCommerce Version", the correct version for Woo on your site should be displayed.
  • Select "Help & Support" > "System Status Report". The report should be loaded and displayed without error.

Screenshots

N/A

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. labels Jan 10, 2023
@itsmeichigo itsmeichigo added this to the 11.9 milestone Jan 10, 2023
@peril-woocommerce
Copy link

peril-woocommerce bot commented Jan 10, 2023

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 10, 2023 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8604-a9b489b on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@itsmeichigo itsmeichigo modified the milestones: 11.9 ❄️, 12.0 Jan 16, 2023
@jaclync jaclync self-assigned this Jan 16, 2023
jaclync
jaclync approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a question about the mock response but good to go after it's addressed!

Networking/NetworkingTests/Responses/systemStatus-without-data.json Outdated
@@ -0,0 +1,485 @@
{
"data": {
Copy link
Contributor

@jaclync jaclync Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ is this JSON response supposed to have the data envelope?

Copy link
Contributor Author

@itsmeichigo itsmeichigo Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching! Fixed in a9b489b.

@itsmeichigo itsmeichigo enabled auto-merge January 16, 2023 06:07
@itsmeichigo itsmeichigo merged commit 26893e9 into trunk Jan 16, 2023
@itsmeichigo itsmeichigo deleted the feat/8602-system-status-migration branch January 16, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaclync jaclync jaclync approved these changes

@selanthiraiyan selanthiraiyan Awaiting requested review from selanthiraiyan

Assignees

@jaclync jaclync

Labels

feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. type: task An internally driven task.

Projects

None yet

Milestone

12.0

Development

Successfully merging this pull request may close these issues.

REST API: Migrate system status endpoints

4 participants

@itsmeichigo @wpmobilebot @jaclync